ben-manes / caffeine / #5564 / 1

100%

master: 100%

push

github

Use immutable entries in EntrySet.removeIf (match CHM)

ConcurrentHashMap and Guava hand removeIf's predicate an immutable
snapshot so setValue throws (JDK-8078726); only iterator/toArray are
write-through. Caffeine diverged: the sync views passed a
WriteThroughEntry (unbounded passed a raw map entry whose setValue
silently bypassed notifications), and the async raw view inherited the
default removeIf, removing positionally rather than conditionally.

Hand the predicate a Map.entry() snapshot and remove conditionally in
the bounded and unbounded views; the async views delegate to the inner
cache's entrySet().removeIf, mirroring their values().removeIf.

4045 of 4056 branches covered (99.73%)

8247 of 8248 relevant lines covered (99.99%)

1.0 hits per line