umputun / revdiff / 28003132735 / 1
90%
master: 90%

DEFAULT BRANCH: master
Ran
Files 71
Run time 4s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.929% (-0.08%) from 90.004%
28003132735.1

push

github

web-flow 
feat(ui): Open focused source in editor (#233)

* feat(ui): Open focused source in editor

Add an `open_file_in_editor` action for the diff pane so reviewers can
jump from the focused row to the current worktree file in their configured
editor.
The default binding is `e`.
`Ctrl+E` keeps the existing annotation-editor behavior.

Line navigation is best effort for worktree-backed reviews.
Added and context rows request their current line,
removed rows use the nearest current source line,
and staged or ref reviews still request a line without reloading the
displayed diff after a clean editor exit.

The editor package owns command construction and source-file checks,
so the UI only maps diff state to an editor target and status hint.
Documentation and plugin references describe the new action,
resolver order,
line syntax,
and reload behavior.

* fix(ui): Reject collapsed delete rows for editor

Collapsed delete-only placeholders are rendered as the first removed row
from the underlying diff.
Opening the source editor from that row previously followed the normal
removed-line fallback and could jump to a nearby current worktree line.

Treat collapsed removed rows that are placeholders or hidden rows as
selection errors instead.
Expanded removed rows keep the existing best-effort behavior and still
open the nearest current worktree line.

Regression coverage exercises the placeholder rejection and the expanded
removed-row fallback.

* golangci-lint fixes

* guard against worktree escape

Source editor targets should reject repository-relative paths that
leave the worktree before launching the editor.

Reject lexical escapes with filepath.IsLocal.
Reject symlink escapes with os.Root.

Per os.Root docs:

> Methods on Root will follow symbolic links,
> but symbolic links may not reference a location outside the root.
> Symbolic links must not be absolute.

* block source edits with line annotations

Opening a worktree file in the source editor can reload the di... (continued)

10349 of 11508 relevant lines covered (89.93%)

3110.22 hits per line

Source Files on job 28003132735.1