ben-manes / caffeine / #5496 / 1

100%

master: 100%

push

github

Refactor the node and cache code generators

Replace the untyped Set<List<Object>> combinations and the parallel
@Nullable Feature[] featureByIndex array with a cartesian product of
Optional<Feature> dimensions, flattened to the present features in encounter
order. Eviction is modeled as one mutually-exclusive dimension (none, size, or
weight), which removes the MAXIMUM_WEIGHT-supersedes-MAXIMUM_SIZE fixup.

Share the driving machinery by composition: a FactoryGenerator is configured
with the feature matrix, the class-name encoding, and a SpecFactory that builds
a single specialization, so the node and local-cache generators no longer
duplicate generate()/writeJavaFile()/reformat() and the parent/child
derivation. Each generator is now just its configuration -- a rule list, a
matrix, an encode alphabet, and a makeSpec method reference.

The generated sources are byte-identical.

4034 of 4042 branches covered (99.8%)

8218 of 8218 relevant lines covered (100.0%)

1.0 hits per line