KarpelesLab / libwallet / 26324150192 / 1
22%
master: 22%

DEFAULT BRANCH: master
Ran
Files 123
Run time 9s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 22.094%. Remained the same
26324150192.1

push

github

MagicalTux 
wltwallet+dart: stop letting the host pick the reshare ceremony's curve

Two layers were conspiring to mis-route reshare ceremonies:

1. dart/lib/src/models/wallet.dart — Wallet.fromJson silently
   defaulted a missing `Curve` field to `'secp256k1'`. An ed25519
   wallet whose serialised payload dropped or blanked the field
   appeared as a secp256k1 wallet to the host (Tibane), which then
   read `wallet.curve` to pick the next ceremony. Default removed;
   missing now means empty so the host has a chance to notice.

2. wltwallet/remote.go — `RemoteKey:reshare` (the libwallet
   endpoint + Dart `RemoteKeyApi.reshare` wrapper) took a `curve`
   parameter and forwarded it to `Crypto/WalletSign:reshare`. The
   WalletSign backend already records the remote key's curve at
   issue time; passing it back in only opened the door for a wrong
   host-side value to overrule the authoritative one. The `Curve`
   field is removed from the input struct and the rest.Param. The
   internal `remoteReshare` helper signature drops the curve arg
   too (only used by remote_test.go, updated).

Net effect — curve/protocol now flow from where they're
authoritative (the Wallet row server-side, the remote key record
on Crypto/WalletSign) rather than being re-derived from a host
cache that might have lost the field. Breaking change for one
endpoint: callers of `remoteKeys.reshare(key: …, curve: …)` need
to drop the `curve:` argument.

CHANGELOG entry under 0.4.41.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

4026 of 18222 relevant lines covered (22.09%)

103.34 hits per line

Source Files on job 26324150192.1