dangernoodle-io / breadboard / 26203839786 / 1

100%

main: 100%

push

github

feat(bb_http,bb_nv): harden SSE/chunked-emit lwip path + manifest provisioned (#295)

Three related changes bundled into one consumer-visible upgrade:

1. bb_http Kconfig BB_HTTP_LWIP_SEM_PER_THREAD (default y) selects
   LWIP_NETCONN_SEM_PER_THREAD. Moves the per-call op_completed_sem out
   of the netconn / select_cb struct and into per-thread TLS. Closes
   two related abort classes:
   - tcpip_send_msg_wait_sem aborting when a peer RST frees the netconn
     between bb_http_resp_send_chunk calls (chunked JSON emit, SSE
     log/event streamers). Reproduced on bitaxe-650.
   - lwip_select aborting when a closed socket frees its select_cb while
     httpd's select loop is mid-wait. Reproduced on tdongle-s3.
   ~1 KB heap cost per firmware (one sem per thread that touches lwip);
   easily worth it on any consumer running SSE under normal browser
   load. Escape hatch: set BB_HTTP_LWIP_SEM_PER_THREAD=n.

2. bb_http_resp_send_chunk peer-liveness probe (defense in depth, gated
   by BB_HTTP_RESP_SEND_CHUNK_LIVENESS_PROBE, default y). Non-blocking
   MSG_PEEK on the underlying socket before each chunk send so a peer
   that already closed surfaces as an early BB_ERR_INVALID_STATE
   return rather than dragging the chunked emitter through N more
   no-op sends. Does not fully close the race (RST can land between
   probe and lwip_send) but stops long-tail writes into dead sockets
   — particularly relevant for bb_log_routes / bb_event_routes SSE.
   The zero-length terminator (len==0) is allowed through so callers
   can finalize chunked responses in their cleanup path.

3. bb_nv s_bb_cfg_keys[] gains a "provisioned" entry so it surfaces in
   /api/manifest. taipan-cli's direct-NVS-flash workflow reads the
   manifest to discover valid keys for pre-seeding. The C API
   (bb_nv_config_is_provisioned, _set_, _clear_) already used the
   string; this just makes it discoverable via the documented schema.

Resolves B1-223, B1-224, B1-225.

1142 of 1142 branches covered (100.0%)

Branch coverage included in aggregate %.

2036 of 2036 relevant lines covered (100.0%)

952.31 hits per line