1
62%
master: 69%

Ran 19 May 2026 02:34PM UTC

Files 40

Run time 3s

Badge

Embed ▾

Committed 19 May 2026 02:29PM UTC coverage: 62.134%. Remained the same

Job # 26103881145.1

Build Type

Pull #3324

github

Committed by

krishdef7

Commit Message

feat(api): Add terminationGracePeriodSeconds to PodSpecPatch in TrainJob

Adds terminationGracePeriodSeconds field to PodSpecPatch so users can
configure pod termination grace period per TrainJob via RuntimePatches.

This is needed for distributed training with PyTorch Elastic (torchrun)
where large models (70B+ parameters) require more than the default 30s
to complete JIT checkpointing before SIGKILL on node drain or TrainJob
pause.

No changes to merge logic in trainingruntime.go are required since the
existing StrategicMergePatch applied at batchv1.JobTemplateSpec level
already handles this field automatically.

Closes #3285

Signed-off-by: krishdef7 <gargkrish06@gmail.com>

Pull Request Pull Request #3324: feat(api): Add terminationGracePeriodSeconds to PodSpecPatch in TrainJob

Coverage Stats

2184 of 3515 relevant lines covered (62.13%)

0.72 hits per line

kubeflow / trainer / 26103881145 / 1
62%
master: 69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 26103881145.1

kubeflow / trainer / 26103881145 / 1 62% master: 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 26103881145.1

kubeflow / trainer / 26103881145 / 1
62%
master: 69%

README BADGES
x