rust-bitcoin / rust-bitcoin / 25945382171 / 1

82%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#6147: p2p: backport add a hash value to Inventory's Error variant to 0.32.x

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/30021ed1e55b85fd202abe0fb536823b45db5ad6">30021ed1e<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/61d09e6d20a59502c1f8459d72408ca3e2bb517c"> Add a hash value to Inventory&#39;s Error variant (Nick Johnson)

Pull request description:

  Backporting #3789 for the 0.32.x consensus_encoding fuzzing: https://github.com/rust-bitcoin/rust-bitcoin/pull/6140#issuecomment-4409398179
  
  Simply cherry-picking the change won&#39;t work since it is not backwards compatible. We had a recent tweak to the `0.32.x` decoding logic in #6140 which makes sure the reader consumes 32 bytes, but it still doesn&#39;t hold on to them, so the fuzztests fail when comparing 32 random fuzz input bytes to 32 zeroes.
  
  This tweaked backport abuses the `Unknown` variant and decodes errors into it in order to hang on to the bytes in an API backwards compatible way. I believe this change would allow us to remove this skip in the differential fuzz tests: https://github.com/rust-bitcoin/rust-bitcoin/blob/<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5485a49d10e808a238c0dffb3a46a1153fa2c31a">5485a49d1</a>/fuzz/fuzz_targets/bitcoin/compare_consensus_encoding.rs#L230-L234


ACKs for top commit:
  tcharding:
    ACK 30021ed1e55b85fd202abe0fb536823b45db5ad6
  apoelstra:
    ACK 30021ed1e55b85fd202abe0fb536823b45db5ad6; successfully ran local tests


Tree-SHA512: c4f16eae55a929c8f1ef7aa35bbcf5edd69

16555 of 20230 relevant lines covered (81.83%)

17614.87 hits per line