Azure / ARO-RP / 25899897882 / 2
38%
master: 38%

DEFAULT BRANCH: master
Ran
Files 313
Run time 9s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 20.542%. Remained the same
25899897882.2

push

github

web-flow 
feat: add script to deploy Azure OpenAI for Holmes admin API (#4764)

* feat: add script to deploy Azure OpenAI for Holmes admin API

Add hack/devtools/deploy-holmes-aoai.sh that provisions an Azure OpenAI
resource and deploys a GPT-5.2 model for the Holmes investigation API.
The script retrieves credentials and writes them to secrets/env so they
are shared via make secrets.

Non-secret config (HOLMES_IMAGE, HOLMES_MODEL, HOLMES_DEFAULT_TIMEOUT,
HOLMES_MAX_CONCURRENT) is added to env.example.

ARO-25985

* fix: address PR review comments for Holmes AOAI deploy script

- Validate api_key and api_base are non-empty before modifying
  secrets/env to prevent destroying working credentials
- Replace sed -i'' with grep + temp file + mv for macOS/Linux
  portability
- Use replace_with_... placeholder for HOLMES_IMAGE instead of
  personal quay.io image
- Add make secrets prerequisite step in docs

* fix: address copilot review feedback for Holmes AOAI deploy script

- Fix grep -v with set -e: add || true to handle case where all lines match filter
- Fix mktemp atomicity: create temp file in same directory as secrets/env for atomic mv
- Improve script robustness for edge cases while maintaining portability

* fix: update HOLMES_IMAGE to use internal ACR in env.example

- Replace placeholder with arointsvc.azurecr.io/holmes:latest
- Update comment to clarify override capability
- Follow existing ACR naming pattern used by ARO_IMAGE

* fix: address latest copilot review feedback

- Fix working directory dependency: add cd to repo root in update_secrets_env
- Fix mktemp portability: use -p flag for cross-platform compatibility
- Fix documentation typo: "Libary" → "Library"
- Add Azure storage prerequisites note for make secrets command

Addresses copilot comments from 2026-05-15

* fix: address final copilot feedback - quote escaping and blank lines

- Fix single quote vulnerability: use printf %q for safe credential escaping
- Fix blank line accumulation: updat... (continued)

3670 of 17866 relevant lines covered (20.54%)

0.24 hits per line

Source Files on job pkg-util - 25899897882.2