pulibrary / bibdata / 7cd0b188-4154-408c-983a-5c36ee59ffb9 / 2
91%
main: 91%

LAST BUILD BRANCH: dense-vector-field
DEFAULT BRANCH: main
Ran
Files 110
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.188% (+2.3%) from 89.927%
7cd0b188-4154-408c-983a-5c36ee59ffb9.2

Pull #3280

circleci

christinach 
This part was moved in pull request
https://github.com/pulibrary/bibdata/pull/3281/changes/9c8450db0

In this commit we keep only the require 'sidekiq/api'

refactor the helper test method run_all_callbacks

zadd - a redis command that adds a member to a sorted set with a numeric score.
Redis sorted sets store members in order by their score.

Pro 7 — score based when Batch.new was called creation time + expiry:
m.zadd("batches", @created_f + expiry, bid)

Pro 8 — score based when the jobs block finishes, now + expiry:
m.zadd("batches", (Time.now + expiry).to_f, bid)

This difference changes to_a ordering only in tests because of the Sidekiq::Testing.inline!: with inline! the jobs calls perform_async which runs the job synchronously. this job calls index_next_dump
to_a order in pro7 is [parent,child] <- ZRANGE
to_a order in pro8 is [child, parent] <- ZRANGE

In pro7 the test assumes that to_a.last is the child because of the ZRANGE.
In pro8 the parent will not finish until everything inside the parent block has run. because of the ZRANGE if we use to_a.last the parent will wait for everyhting inside to run then it will run last and the reindex! will call .wipe! and delete the records that were indexed from the child. So in this case to_a.last will call the parent.
Pull Request #3280: Sidekiq connection pool

2950 of 3200 relevant lines covered (92.19%)

265.43 hits per line

Source Files on job 7cd0b188-4154-408c-983a-5c36ee59ffb9.2