1
91%
main: 91%

Ran 13 May 2026 02:01PM UTC

Files 89

Run time 3s

Badge

Embed ▾

Committed 13 May 2026 01:56PM UTC coverage: 89.927% (-2.3%) from 92.188%

Job # 5c71f188-1aa4-40c6-8059-6cda722df575.1

Build Type

Pull #3280

circleci

Committed by

christinach

Commit Message

refactor the helper test method run_all_callbacks

zadd - a redis command that adds a member to a sorted set with a numeric score.
Redis sorted sets store members in order by their score.

Pro 7 — score based when Batch.new was called creation time + expiry:
m.zadd("batches", @created_f + expiry, bid)

Pro 8 — score based when the jobs block finishes, now + expiry:
m.zadd("batches", (Time.now + expiry).to_f, bid)

This difference changes to_a ordering only in tests because of the Sidekiq::Testing.inline!: with inline! the jobs calls perform_async which runs the job synchronously. this job calls index_next_dump
to_a order in pro7 is [parent,child] <- ZRANGE
to_a order in pro8 is [child, parent] <- ZRANGE

In pro7 the test assumes that to_a.last is the child because of the ZRANGE.
In pro8 the parent will not finish until everything inside the parent block has run. because of the ZRANGE if we use to_a.last the parent will wait for everyhting inside to run then it will run last and the reindex! will call .wipe! and delete the records that were indexed from the child. So in this case to_a.last will call the parent.

Pull Request Pull Request #3280: Sidekiq connection pool

Coverage Stats

8062 of 8965 relevant lines covered (89.93%)

19.84 hits per line

pulibrary / bibdata / 5c71f188-1aa4-40c6-8059-6cda722df575 / 1
91%
main: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5c71f188-1aa4-40c6-8059-6cda722df575.1

pulibrary / bibdata / 5c71f188-1aa4-40c6-8059-6cda722df575 / 1 91% main: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5c71f188-1aa4-40c6-8059-6cda722df575.1

pulibrary / bibdata / 5c71f188-1aa4-40c6-8059-6cda722df575 / 1
91%
main: 91%

README BADGES
x