1
100%
master: 100%

Ran 13 Sep 2016 01:36AM UTC

Files 96

Run time 6s

Badge

Embed ▾

Committed 13 Sep 2016 01:23AM UTC coverage: 70.542%. Remained the same

Job # 3117.1

Build Type

push

travis-ci

Committed by

coolo

Commit Message

dead worker check: use 15 secs not 10, better names, comments (#864)

As discussed in #848, it's kind of racy to have the workers
POST a status update every 10 seconds, and have the dead worker
check consider any worker which hasn't updated in the last 10
seconds 'dead'. It doesn't allow for there being a slight delay
in POSTing the update (which can happen if the worker is busy
doing something else when the 10 second timer should trigger
the update) or in the update being actually received and
processed by the server. So let's just change the threshold for
the check to 15 seconds.

While I'm at it, I figured we could make the subroutine names
a bit clearer: since the DB query subroutine isn't really the
ultimate arbiter of whether the worker is truly 'dead' or not
any more, let's call that `_get_stale_worker_jobs` instead of
`_get_dead_worker_jobs` (and call its result `$stale_jobs` not
`$dead_jobs`). This should make the code a bit less confusing
to anyone reading it fresh.

Also, coolo's changes from #848 changed the behaviour here
without updating all the comments; update a couple of comments
and explain a bit more in them.

Run Details

4241 of 6012 relevant lines covered (70.54%)

100.18 hits per line

os-autoinst / openQA / 3117 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3117.1

os-autoinst / openQA / 3117 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3117.1

os-autoinst / openQA / 3117 / 1
100%
master: 100%

README BADGES
x