ForumMagnum / ForumMagnum / 25463223484 / 1

48%

master: 47%

Pull #12497

github

Revert Elasticsearch bulk-indexer rejected filter

Drop the WHERE "rejected" IS NOT TRUE clauses I added to
PostsRepo/CommentsRepo getSearchDocuments and countSearchDocuments.

The prevailing pattern for the ES index is "index every row, filter
at query time": ElasticConfig.ts strips draft, rejected, deleted,
authorIsUnreviewed, retracted, spam, etc. from search results, while
elasticSyncDocument re-indexes every row on update via
getSearchDocumentById, which has no per-row filter. So filtering at
bulk-export time only created an inconsistent state — rejected posts
disappeared after a recreateIndex but came back the next time they
were updated. The query-time filter already handles it.

4810 of 6722 branches covered (71.56%)

Branch coverage included in aggregate %.

125045 of 373111 relevant lines covered (33.51%)

34.62 hits per line