ForumMagnum / ForumMagnum / 25407457020 / 2

48%

master: 47%

push

github

Filter rejected comments and clean up notifications on rejection

In preparation for enabling the rejection feature on EA Forum, fix six
queries that returned rejected comments to public-facing surfaces, fix
two queries that included rejected comments in user-visible counts, and
add notification cleanup so rejecting content also marks the related
inbox notifications as deleted.

Public feed leaks (added rejected filter to SQL):
- getCommentsWithReacts: powers the public CommentsWithReacts paginated
  resolver. A rejected comment with a reaction would surface in the feed.
- getPopularComments: powers the public PopularComments resolver, which
  feeds into the homepage popular-comments rail. A rejected comment with
  high baseScore would surface there.
- getRecentCommentsOnPosts: backstop on the SQL itself, since the result
  goes through accessFilterMultiple/commentCheckAccess and we intentionally
  allow direct-by-id access to rejected comments for the moderation log.

User-visible count leaks (added rejected filter to SQL):
- getCommentsPerDay: per-post engagement chart, was inflating daily counts.
- getAuthorshipStats: Wrapped year-in-review, was inflating both the
  user's count and their percentile.
- getUsersMostCommentedPostSince: inactive-user-summary digest email,
  was inflating the count emailed to users.

Defense-in-depth on the search index:
- CommentsRepo.getSearchDocuments / countSearchDocuments: skip rejected
  comments during bulk Elasticsearch reindex, mirroring the previous
  PostsRepo fix. Query-time filtering in ElasticConfig already excludes
  rejected, so this is hygiene, not a leak fix.

Notification cleanup on hide:
- Extend removeRedraftNotifications to also fire when a post transitions
  from public to rejected (previously it only fired on the redraft
  transition, leaving orphan notifications when a published post was
  rejected).
- Add a parallel removeCommentNotificationsOnHidden callback that fires
  on the public→non-pub... (continued)

4949 of 6286 branches covered (78.73%)

Branch coverage included in aggregate %.

157274 of 372525 relevant lines covered (42.22%)

1.93 hits per line