tarantool / tarantool / 25040565762 / 1

88%

master: 88%

push

github

iproto: fix double-free of user name with multiple serving threads

When an IPROTO connection is created with `box.session.new()`, we
store a pointer to the same user name in each serving thread's runtime
credentials. Thus when the connection is deleted, the same user name
will be freed multiple times (once for each serving thread), which is
a bug. Let's fix it by creating a copy of the user name for each serving
thread.

The bug slipped through because luatest didn't detect bugs reported by
the address sanitizer at exit, see tarantool/luatest#460.

Closes #12631

NO_DOC=bug fix
NO_TEST=covered by existing tests

70668 of 118964 branches covered (59.4%)

106333 of 121286 relevant lines covered (87.67%)

1336036.25 hits per line