valkyrjaio / sindri-php / 24949085513 / 1
100%
26.x: 100%

DEFAULT BRANCH: 26.x
Ran
Files 79
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
24949085513.1

push

github

web-flow 
[Sindri] Emit constant references for route names, paths, and array keys (#32)

# Description

Route names, paths, and routing-data array keys that originate from
class-constant references (e.g. `CommandName::HELP`) were being emitted
as quoted string literals in generated files. The root cause was that
`extractExprValue` normalises a `ClassConstFetch` AST node to the string
`"FQN::CASE"`, and every downstream code-generation path then
unconditionally wrapped that string in single quotes or passed it
through `buildStringExpr`.

Fixed by routing all name, path, and array-key values through
`buildEnumCaseExpr`, which already knows to produce a `ClassConstFetch`
node when the string contains `::` and fall back to `String_` otherwise.
The same fix is applied to the route-name values stored inside the HTTP
`paths` / `dynamicPaths` / `regexes` nested arrays.

---

## Types of Changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

- **`src/Sindri/Ast/CliRouteAttributeReader.php`** — `name:` named arg
now uses `buildEnumCaseExpr` instead of `buildStringExpr`
- **`src/Sindri/Ast/HttpRouteAttributeReader.php`** — `name:` and
`path:` named args now use `buildEnumCaseExpr` instead of
`buildStringExpr`
- **`src/Sindri/Generator/Abstract/AstFileGenerator.php`** — added
`buildEnumCaseExpr` helper (mirrors the one in `AstReader`) so both
concrete generators can use it
- **`src/Sindri/Generator/Ast/Cli/AstCliDataFileGenerator.php`** —
`getRoutesAsContent()`: array key printed via
`prettyPrintExpr(buildEnumCaseExpr($key))` instead of `'$key'`
- **`src/Sindri/Generator/Ast/Http/AstHttpDataFileGenerator.php`** —
same key fix in ... (continued)

1532 of 1532 relevant lines covered (100.0%)

16.36 hits per line

Source Files on job 24949085513.1