kubeovn / kube-ovn / 24831150934 / 1
25%
master: 25%

LAST BUILD BRANCH: renovate/master-golangci-lint-2.x
DEFAULT BRANCH: master
Ran
Files 206
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 24.598% (+0.04%) from 24.555%
24831150934.1

push

github

oilbeater 
fix(controller): keep VM LSP port-group memberships when a sibling pod is alive (#6666)

* fix(controller): keep VM LSP port-group memberships when a sibling pod is alive

For VM pods with EnableKeepVMIP=true a single LSP is shared across every
virt-launcher pod of the VM (ExternalIDs["pod"] is keyed by VM name, not
by pod name). When kubernetes GCs a completed virt-launcher pod — most
commonly the source of a successful live migration — handleDeletePod
finds that LSP, and because isVMToDel is false it calls
RemovePortFromPortGroups(port.Name) with no port-group names, which
strips the LSP from every port group (node, subnet, security group,
network policy).

The LSP is still in use by the currently running destination pod, so the
active VM pod loses its memberships and connectivity until
kube-ovn-controller is restarted and all pods are re-synced.

Before stripping port-group memberships in the keepIPCR branch, check
whether another alive virt-launcher pod exists for the same VMI. If so,
the memberships belong to that sibling and must be preserved.

Fixes #6665

Signed-off-by: Andrei Kvapil <andrei.kvapil@aenix.io>

* fix(controller): rewrite vm lsp cleanup if-else chain as switch

Satisfies gocritic's ifElseChain rule; no behavior change.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Andrei Kvapil <andrei.kvapil@aenix.io>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Mengxin Liu <liumengxinfly@gmail.com>

13844 of 56280 relevant lines covered (24.6%)

0.29 hits per line

Source Files on job 24831150934.1