ben-manes / caffeine / #5394 / 1

100%

master: 100%

push

github

Correct WeakValueReference keyReference design note

The prior note described keyReference as "set once during construction
and never mutated", which is inaccurate: retire() and die() on generated
weak/soft-value nodes write sentinels into the field under
synchronized(node). The note also attributed the storeStoreFence's role
to publishing the newly-constructed reference's non-final fields;
the actual load-bearing role (per the JCStress IntermittentNull test) is
ordering the old reference's ref.clear() against the setRelease of the
new reference so the getValue re-check loop's invariant holds.

3894 of 3902 branches covered (99.79%)

7993 of 7993 relevant lines covered (100.0%)

1.0 hits per line