1
8%
master: 8%

Ran 08 Sep 2016 12:52PM CUT

Files 12

Run time 1s

Badge

Embed ▾

Committed 08 Sep 2016 12:48PM CUT coverage: 86.826% (-7.4%) from 94.246%

Job # USE_SA=1 PYTHONASYNCIODEBUG=x

Build Type

push

travis-ci

Committed by

asvetlov

Commit Message

Remove callbacks from a bad file descriptor immediately (#139)

* Remove callbacks from a bad file descriptor immediately

Previously, the callback removal was postponed until .close() call, and
sometimes this .close() call cleared a file descriptor from a callback set
by another connection object (if the file desriptor was closed by psycopg2 when
an error occurred, and then opened again for a new connection).

The effect of this was, when making tens of parallel connections, an error in
one of them made another time out.

Now, if a psycopg2 error occurs, and the file descriptor has gone bad, the
callback is removed immediately, and the aiopg connection object 'forgets'
about this file descriptor (self._fileno = None), and doesn't try to remove
callbacks in .close().

If there were no errors, callbacks are still removed during .close() call.

* Use contextlib.suppress for brevity

Run Details

1127 of 1298 relevant lines covered (86.83%)

0.87 hits per line

Source Files on job 494.1 (USE_SA=1 PYTHONASYNCIODEBUG=x)

Show entries

Search:

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
58.91	aiopg/utils.py	227 + 182	129 + 129	76 + 76	53 + 53	1.0 + 1.0
77.33	aiopg/sa/transaction.py	185 + 141	75 + 75	58 + 58	17 + 17	1.0 + 1.0
87.04	aiopg/sa/connection.py	365 + 307	162 + 162	141 + 141	21 + 21	1.0 + 1.0
89.33	aiopg/pool.py	314 + 246	178 + 178	159 + 159	19 + 19	1.0 + 1.0
90.37	aiopg/connection.py	494 + 462	270 + 258	244 + 233	26 + 25	1.0 - 4
91.33	aiopg/sa/result.py	429 + 421	196 + 191	179 + 174	17 + 17	1.0
92.11	aiopg/cursor.py	401 + 359	152 + 152	140 + 140	12 + 12	1.0 + 1.0
93.94	aiopg/sa/engine.py	225 + 218	99 + 95	93 + 89	6 + 6	1.0
100.0	aiopg/sa/exc.py	27 - 20	5 + 5	5 + 5	0	1.0 + 1.0
100.0	aiopg/__init__.py	45 + 17	25 + 25	25 + 25	0	1.0 + 1.0

Showing 1 to 10 of 12 entries

aio-libs / aiopg / 494 / 1
8%
master: 8%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 494.1 (USE_SA=1 PYTHONASYNCIODEBUG=x)

aio-libs / aiopg / 494 / 1 8% master: 8%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 494.1 (USE_SA=1 PYTHONASYNCIODEBUG=x)

aio-libs / aiopg / 494 / 1
8%
master: 8%

README BADGES
x