1
8%
master: 8%

Ran 08 Sep 2016 12:52PM UTC

Files 12

Run time 1s

Badge

Embed ▾

Committed 08 Sep 2016 12:48PM UTC coverage: 86.826% (-7.4%) from 94.246%

Job # USE_SA=1 PYTHONASYNCIODEBUG=x

Build Type

push

travis-ci

Committed by

asvetlov

Commit Message

Remove callbacks from a bad file descriptor immediately (#139)

* Remove callbacks from a bad file descriptor immediately

Previously, the callback removal was postponed until .close() call, and
sometimes this .close() call cleared a file descriptor from a callback set
by another connection object (if the file desriptor was closed by psycopg2 when
an error occurred, and then opened again for a new connection).

The effect of this was, when making tens of parallel connections, an error in
one of them made another time out.

Now, if a psycopg2 error occurs, and the file descriptor has gone bad, the
callback is removed immediately, and the aiopg connection object 'forgets'
about this file descriptor (self._fileno = None), and doesn't try to remove
callbacks in .close().

If there were no errors, callbacks are still removed during .close() call.

* Use contextlib.suppress for brevity

Run Details

1127 of 1298 relevant lines covered (86.83%)

0.87 hits per line

Source Files on job 494.1 (USE_SA=1 PYTHONASYNCIODEBUG=x)

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

aio-libs / aiopg / 494 / 1
8%
master: 8%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 494.1 (USE_SA=1 PYTHONASYNCIODEBUG=x)

aio-libs / aiopg / 494 / 1 8% master: 8%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 494.1 (USE_SA=1 PYTHONASYNCIODEBUG=x)

aio-libs / aiopg / 494 / 1
8%
master: 8%

README BADGES
x