bitcoindevkit / bdk-sp / 24358968317 / 1

26%

master: 26%

push

github

Merge bitcoindevkit/bdk-sp#57: Scanning fails when birthday block does not exist

<a class=hub.com/bitcoindevkit/bdk-sp/commit/c5c22ad1899ea1872a97ca4fba3971339f8980a8">c5c22ad18 fix(cliv2): scanning fails when birthday block does not exist (nymius)

Pull request description:

  When the wallet is just created, there is no blocks on the `LocalChain`, making the request of the birthday checkpoint impossible to serve.

  This change avoids the issue by directly using the height and hash set on the wallet.birthday field.

ACKs for top commit:
  nymius:
    self ACK c5c22ad1899ea1872a97ca4fba3971339f8980a8

Tree-SHA512: 5c9b7f6433aa89273e45bc11f25eb8faa95

74 of 94 branches covered (78.72%)

Branch coverage included in aggregate %.

819 of 3273 relevant lines covered (25.02%)

10.11 hits per line