1
62%
master: 69%

Ran 13 Mar 2026 11:32AM UTC

Files 34

Run time 1s

Badge

Embed ▾

Committed 13 Mar 2026 11:28AM UTC coverage: 59.356%. Remained the same

Job # 23048805264.1

Build Type

Pull #3324

github

Committed by

krishdef7

Commit Message

feat(api): Add terminationGracePeriodSeconds to PodSpecPatch in TrainJob

Adds terminationGracePeriodSeconds field to PodSpecPatch so users can
configure pod termination grace period per TrainJob via RuntimePatches.

This is needed for distributed training with PyTorch Elastic (torchrun)
where large models (70B+ parameters) require more than the default 30s
to complete JIT checkpointing before SIGKILL on node drain or TrainJob
pause.

No changes to merge logic in trainingruntime.go are required since the
existing StrategicMergePatch applied at batchv1.JobTemplateSpec level
already handles this field automatically.

Closes #3285

Signed-off-by: krishdef7 <gargkrish06@gmail.com>

Pull Request Pull Request #3324: feat(api): Add terminationGracePeriodSeconds to PodSpecPatch in TrainJob

Coverage Stats

1732 of 2918 relevant lines covered (59.36%)

0.69 hits per line

kubeflow / trainer / 23048805264 / 1
62%
master: 69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 23048805264.1

kubeflow / trainer / 23048805264 / 1 62% master: 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 23048805264.1

kubeflow / trainer / 23048805264 / 1
62%
master: 69%

README BADGES
x