1
64%
master: 65%

Ran 04 Mar 2026 07:16PM UTC

Files 89

Run time 2s

Badge

Embed ▾

Committed 04 Mar 2026 06:51PM UTC coverage: 63.87% (+0.02%) from 63.852%

Job # 5839974563577856.1

Build Type

Pull #10509

CirrusCI

Committed by

SomberNight

Commit Message

lnpeer: simplify where maybe_send_commitment() is called

The typical flow of an update is:
---UPDATE--->
--- SIG  --->
<--REVACK----
<-- SIG  ----
---REVACK--->

It makes sense to try to send a sig ("commitment_signed") right after we send an update.
It also makes sense right after we send revack.

Besides those times, we could call "maybe_send_commitment" at *any* time, that is safe, and depending on other call locations, it might be an optimisation, however it is not needed.

In particular it is unclear why we had those calls when we *receive* updates (and only for certain types of updates - not consistently).

Pull Request Pull Request #10509: lnpeer: simplify where maybe_send_commitment() is called

Coverage Stats

24555 of 38445 relevant lines covered (63.87%)

0.64 hits per line

spesmilo / electrum / 5839974563577856 / 1
64%
master: 65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5839974563577856.1

spesmilo / electrum / 5839974563577856 / 1 64% master: 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5839974563577856.1

spesmilo / electrum / 5839974563577856 / 1
64%
master: 65%

README BADGES
x