Idrinth / habit-evaluator / 22300149186 / 8

40%

the-one: 40%

push

github

Fix emergency plan actions lost when reordering steps on Android (#588)

When moving a question up/down, the swapOrder function saved steps back
to the repository. The save method called saveStepWithActions which
deleted existing actions and re-inserted them from the model. However,
actions loaded from the database had no step backreference (step=null),
so toEntity() produced actionEntities with stepId="" instead of the
real step ID — effectively orphaning them.

Fix: (1) set step backreference on actions during loading in findById,
findAll, and findByUserId; (2) explicitly copy the parent step ID onto
action entities in save, saveAll, and saveSuspend as defense-in-depth.

https://claude.ai/code/session_01XzJHSPiimYf9u2jcxWGJNp

Co-authored-by: Claude <noreply@anthropic.com>

51 of 213 branches covered (23.94%)

Branch coverage included in aggregate %.

279 of 634 relevant lines covered (44.01%)

4.62 hits per line