bitcoindevkit / bdk / 21778649128 / 1

78%

master: 78%

push

github

Merge bitcoindevkit/bdk#2083: fix: no `Debug` on `Display` implementations

<a class=hub.com/bitcoindevkit/bdk/commit/823e4e980af03672cc6342d0e4850febcbd14c9d">823e4e980<a href="https://github.com/bitcoindevkit/bdk/commit/b45ecb9bd41c80a03921dcf42a9845b19774502e"> fix(file_store)!: remove Debug usage and implement Display for StoreError. (Dmenec)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/5a85f6e25a9e14204cb66fec3f7381a59133f0be">5a85f6e25</a><a href="https://github.com/bitcoindevkit/bdk/commit/b45ecb9bd41c80a03921dcf42a9845b19774502e"> fix(chain)!: remove Debug usage and implement Display for CalculateFeeError (Dmenec)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/d0889f37ae1176eb1510a8d260cde8e05fe68f76">d0889f37a</a><a href="https://github.com/bitcoindevkit/bdk/commit/b45ecb9bd41c80a03921dcf42a9845b19774502e"> docs(core): add detailed SyncRequest output example (Dmenec)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/5d715c2e4c8076be058e342efe279a3fc3481312">5d715c2e4</a> fix(chain)!: remove Debug usage and implement Display for InsertDescriptorError (Dmenec)

Pull request description:

  ### Description

  Fixes https://github.com/bitcoindevkit/bdk/issues/1933, remove the usage of `Debug` on `Display` implemetations mentioned in https://github.com/bitcoindevkit/bdk/pull/1881#issuecomment-2718412512

  ### Changelog notice

  - Replaced  `Debug` usage with `Display` messages for `InsertDescriptorError`, `CalculateFeeError` and `StoreError`.
  - `InvalidMagicBytes` now displays expected and actual bytes in hexadecimal instead of using `Debug`.
  - Added a new `short_descriptor` function to shorten descriptors for concise error output.
  - Added detailed `SyncRequest` `Display` for Esplora and Electrum examples.

  ### Checklists

  #### All Submissions:
  * [x] I have signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `just check`, `just fmt` and `just test` before committing

ACKs for top commit:
  evanlinjin:
    ACK 823e4e980af03672cc6342d0e4850febcbd14c9d

Tree-SHA512: fc3d66b7223cbb019cc326a47a8258ec1ca

378 of 514 branches covered (73.54%)

Branch coverage included in aggregate %.

4254 of 5390 relevant lines covered (78.92%)

3114.18 hits per line