babelfish-for-postgresql
/
babelfish_extensions
/
21112214931
/
1
76%
BABEL_5_X_DEV: 77%
BABEL_5_X_DEV: 77%
|
Ran
|
Files
120
|
Run time
4s
|
Badge
Embed ▾
README BADGES
|
coverage: 76.274% (+0.01%) from 76.263%
push
github
web-flowFix: Crash when dropping table variable related temp tables due to being in PG dialect (#4410) (#4463) In BABEL-6227, nested calls corrupted the dialect to 'postgres' causing table variable temp table cleanup to fail. In BABEL-6239, nested calls left the dialect as 'postgres' causing subsequent TSQL queries to be parsed with the wrong parser. This is because of using both direct assignment and set_config_option() function together in a nested call stack. The set_config_option() function is PGs GUC setting infrastructure which internally maintains a prev value stack. This does not work well, if caller functions have used direct assignment instead because it would mean that the value does not get registered in the internal GUC stack, leading to restoration of incorrect value for sql_dialect. The fix for this is to use direct assignment in the culprit function which is using set_config_option. Previously, we've made the decision to use direct assignment instead of set_config because of perf related issues. Task - BABEL-6227 & BABEL-6239 (cherry picked from commit 67248ef01) (cherry picked from commit 539592ca8) Signed-off-by: Ayush Shah <ayushdsh@amazon.com>
50678 of 66442 relevant lines covered (76.27%)
392932.06 hits per line
