5
95%
main: 95%

Ran 12 Jan 2026 01:21PM UTC

Files 7

Run time 0s

Badge

Embed ▾

Committed 12 Jan 2026 01:19PM UTC coverage: 94.918% (+0.1%) from 94.784%

Job # 20920836919.5

Build Type

Pull #54

github

Committed by

bjmorgan

Commit Message

Refactor get_sc_fermi to use scipy.optimize.brentq

Replaced custom bisection-like solver with scipy's Brent's method.

Benefits:
- 40x faster (2.6ms vs 102ms per solve)
- Simpler, more robust code
- Well-tested implementation

Changes:
- n_trial_steps is deprecated (emits DeprecationWarning if set)
- convergence_tolerance is now optional and controls Fermi energy
  precision (xtol), not charge neutrality residual
- Both parameters default to scipy's defaults if not specified
- Fixed numerical instability in charge state concentration scaling
  using logsumexp

Closes #52
Closes #53

Pull Request Pull Request #54: Refactor get_sc_fermi to use scipy.optimize.brentq

Run Details

523 of 551 relevant lines covered (94.92%)

0.95 hits per line

bjmorgan / py-sc-fermi / 20920836919 / 5
95%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python-3.8 - 20920836919.5

bjmorgan / py-sc-fermi / 20920836919 / 5 95% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python-3.8 - 20920836919.5

bjmorgan / py-sc-fermi / 20920836919 / 5
95%
main: 95%

README BADGES
x