1
58%
main: 58%

Ran 04 Dec 2025 10:52PM UTC

Files 190

Run time 7s

Badge

Embed ▾

Committed 04 Dec 2025 10:50PM UTC coverage: 57.787% (+0.03%) from 57.761%

Job # 19946522664.1

Build Type

push

github

Committed by

fasterthanlime

Commit Message

fix(facet-reflect): fix UB in `Peek::as_str()` for bare `str` types

Fixes #1082.

The `as_str()` method was using `get::<&str>()` for bare `str` shapes,
which caused UB when the str data was empty (reading 16 bytes from a
0-byte allocation).

The fix distinguishes between bare `str` and `&str`:
- For bare `str`: use `get::<str>()` which creates a reference to the
  str bytes pointed to by the wide pointer
- For `&str`: fall through to the existing pointer handler which
  correctly uses `get::<&str>()` to read the fat pointer from memory

This also improves string equality comparison in facet-diff, which
now correctly identifies equal string fields as unchanged.

Run Details

22820 of 39490 relevant lines covered (57.79%)

502.39 hits per line

facet-rs / facet / 19946522664 / 1
58%
main: 58%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 19946522664.1

facet-rs / facet / 19946522664 / 1 58% main: 58%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 19946522664.1

facet-rs / facet / 19946522664 / 1
58%
main: 58%

README BADGES
x