ProjectOpenSea / opensea-js / 19939517206 / 1

88%

master: 30%

push

github

fix: change Transaction.value type from number to string to prevent overflow (#1836)

JavaScript's Number type can only safely represent integers up to 2^53-1.
When the API returns large wei values (like NFT prices in wei), they can
overflow and become negative values like -1617240366657743600.

This fix changes Transaction.value type from number to string, which:
- Prevents integer overflow for large wei values
- Works with ethers.js which accepts strings as BigNumberish
- Matches how the API should serialize large integer values

474 of 684 branches covered (69.3%)

Branch coverage included in aggregate %.

4105 of 4546 relevant lines covered (90.3%)

4.15 hits per line