Gallopsled / pwntools / 1 / 1

74%

dev: 74%

push

github

fix: Fallback to temp dir if cache does not exist (#1784)

This fixes a misbehaviour in environments where `XDG_CACHE_DIR` is not
set and `~/.cache` does not exist, e.g. in the docker image. We simply
attempt to create a temporary directory which will be registered with
`atexit` to be deleted on exit using `shutil.rmtree()`. A Python 3
approach for future would be to use a `TemporaryDirectory` instead which
would get cleaned up when the held object gets dropped out of the TLS
stack.

It is still possible for the `context.cache_dir` to be `None` if the
default directory exists but is not writable, which means some code
which uses this property is liable to blow up in such a circumstance.

2 of 5730 branches covered (0.03%)

221 of 16511 relevant lines covered (1.34%)

0.01 hits per line