bitcoindevkit / bdk-cli / 19028754066 / 1
8%
master: 8%

DEFAULT BRANCH: master
Ran
Files 5
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 14.43% (+5.6%) from 8.801%
19028754066.1

push

github

tvpeter 
Merge bitcoindevkit/bdk-cli#224: fix(pretty-format): use `--pretty` in any position

c47536393 chore(clippy): clippy fixes (Vadim Anufriev)
daebe5373 test(pretty): add tests for pretty option (Vadim Anufriev)
17a4dcae2 fix(pretty): use pretty option in any position (Vadim Anufriev)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  Fix `--pretty` flag to work in any position by marking it as a global argument.

  Previously the flag only worked before subcommands (`bdk-cli --pretty key generate`) but failed after
    (`bdk-cli key generate --pretty`).

  ### Notes to the reviewers
  **Before the fix:**
  Works:
  ```bash
  -> % cargo run -- --pretty key generate
  +-------------+-----------------------------------------------------------------------------------------------------------------+
  | Fingerprint | 3e68be40                                                                                                        |
  +-------------+-----------------------------------------------------------------------------------------------------------------+
  | Mnemonic    | wheat equip exhaust funny panic lend message champion slim derive alcohol differ                                |
  +-------------+-----------------------------------------------------------------------------------------------------------------+
  | Xprv        | tprv8ZgxMBicQKsPdmyStjLXkChBJnUa5DBVJY5J46C3qbe98623M9uqD9wrDtcSZe4hLCodZdKacuY8YPzrNWFUEUwSrpa12KiEBikwLTjiYWP |
  +-------------+-----------------------------------------------------------------------------------------------------------------+
  ```

  Doesn't work:
  ```bash
  -> % cargo run -- key generate --pretty
  error: unexpected argument '--pretty' found

  Usage: bdk-cli key generate [OPTIONS]

  For more information, try '--help'.
  ```

 ... (continued)

172 of 1192 relevant lines covered (14.43%)

0.54 hits per line

Source Files on job 19028754066.1