igniterealtime / Smack / 19015919539 / 1

40%

master: 40%

push

github

[formtypes] Use central entry point for registry, fixes NPE on Android

FormFieldRegistry would scan the classpath for registry files. However
this does not work on Android, where it fails with an NPE:

Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.security.CodeSource java.security.ProtectionDomain.getCodeSource()' on a null object reference
	at org.jivesoftware.smackx.formtypes.FormFieldRegistry.loadFormFieldRegistryEntries(FormFieldRegistry.java:109)
   	at org.jivesoftware.smackx.formtypes.FormFieldRegistry.<clinit>(FormFieldRegistry.java:56)
   	at org.jivesoftware.smackx.softwareinfo.form.SoftwareInfoForm.<clinit>(SoftwareInfoForm.java:52)
   	at java.lang.Class.classForName(Native Method)
   	at java.lang.Class.forName(Class.java:536)
   	at org.jivesoftware.smack.SmackInitialization.loadSmackClass(SmackInitialization.java:210)
   	at org.jivesoftware.smack.SmackInitialization.parseClassesToLoad(SmackInitialization.java:190)
   	at org.jivesoftware.smack.SmackInitialization.processConfigFile(SmackInitialization.java:164)
   	at org.jivesoftware.smack.initializer.UrlInitializer.initialize(UrlInitializer.java:69)
   	at org.jivesoftware.smack.SmackInitialization.loadSmackClass(SmackInitialization.java:229)
   	at org.jivesoftware.smack.SmackInitialization.parseClassesToLoad(SmackInitialization.java:190)
   	at org.jivesoftware.smack.SmackInitialization.processConfigFile(SmackInitialization.java:167)
   	at org.jivesoftware.smack.SmackInitialization.processConfigFile(SmackInitialization.java:154)
   	at org.jivesoftware.smack.SmackInitialization.<clinit>(SmackInitialization.java:103)
   	at org.jivesoftware.smack.Smack.getVersion(Smack.java:51)
   	at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.loadJabberServiceClasses(ProtocolProviderServiceJabberImpl.java:3144)
   	at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.<clinit>(ProtocolProviderSe... (continued)

3491 of 11961 branches covered (29.19%)

15702 of 39673 relevant lines covered (39.58%)

1.52 hits per line