nielstron / opshin / 17455519698 / 2

91%

dev: 92%

push

github

Fix issue #1 with 2nd Model

Summary of Changes:
The issue was that the time unit difference for POSIX time between Cardano (milliseconds) and Python (seconds) was not documented, leading to potential confusion and errors. The provided patch successfully resolves this issue.

1.  In the core ledger API files (`opshin/ledger/api_v2.py` and `opshin/ledger/api_v3.py`), a clear and explicit comment has been added above the `POSIXTime` type definition. This comment states that the time is in milliseconds and warns the user to multiply Python's standard `time.time()` result by 1000. This directly addresses the "should be documented somehow" part of the issue.
2.  In the example smart contract (`examples/smart_contracts/simple_script.py`), the variable `unixtimestamp` was renamed to `punixtimestamp`, and a comment `# posix time in milliseconds` was added. This change makes the expected unit transparent to developers who use this example as a reference, fulfilling the second part of the issue's request.

Together, these changes effectively document the time unit discrepancy in both the core API definition and in a practical example, resolving the issue.

Duration: 8m 35s

1211 of 1440 branches covered (84.1%)

Branch coverage included in aggregate %.

4663 of 4931 relevant lines covered (94.56%)

0.95 hits per line