tari-project / tari / 17394556887 / 1
62%
development: 62%

DEFAULT BRANCH: development
Ran
Files 699
Run time 20s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 61.161% (+0.08%) from 61.079%
17394556887.1

push

github

web-flow 
feat!: remove comms from wallet (#7432)

Description
---
- Removed comms from wallet.
- Wired in missing information in the wallet's base node connectivity.

Motivation and Context
---
Comms is not used in the wallet anymore.

How Has This Been Tested?
---
- System-level testing on mainnet sending transactions between two
wallets.

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [ ] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [x] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
BREAKING CHANGE: 
- Wallet FFI
  - SAF and DHT callbacks have been removed.
- A new type, `TariWalletDbConfig`, now replaces `TariCommsConfig` -
naming for `comms_config_create` and `comms_config_destroy` have been
retained.
  - These functions have been removed:
    - `wallet_get_seed_peers`
  - These functions have changes to their interfaces:
    - `wallet_create`
    - `wallet_get_last_version`
    - `wallet_get_last_network`
    - `comms_config_destroy`
    - `comms_config_create`
- gRPC
- `ListConnectedPeers` now returns a new response,
`ListConnectedHttpPeersResponse`, instead of
`ListConnectedPeersResponse`. The connected base node's public_key and
node_id are also returned for convenience, along with the connection
URL, latency and online status.
  - `GetNetworkStatus` now includes a degraded status as well
- Cli method `discover_peer` has been removed
- All previous wallet comms config settings were deprecated (no-op), but
config files were kept intact, with notices about deprecated settings.




<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by C... (continued)

72696 of 118861 relevant lines covered (61.16%)

229440.76 hits per line

Source Files on job 17394556887.1