facebookincubator / TTPForge / 17239997386 / 1
51%
main: 67%

LAST BUILD BRANCH: export-D89671295
DEFAULT BRANCH: main
Ran
Files 54
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 51.302%. First build
17239997386.1

Pull #551

github

facebook-github-bot 
TTPForge Move Command (#551)

Summary:
Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/551

# Overview
This diff introduces a `move` command to TTPForge. This command enables you to move forge files while keeping any subttp references intact.

# Context
This implementation spawned from a growing need for reorganization within the growing list of available forges.

View T234255665: [TTPForge] Create Move TTP Command for additional information.

# Future Improvements
Currently, regex pattern matching is used to find and update existing references. Aditional testing should be done to confirm that the regex patterns being tested only update the appropriate references. Additional handling could be added for partial path matches in cases were paths are dynamically generated based on variable values.

When specifying a reference path for the destination (repo//path/to/ttp), the current implementation uses the repository's first search path to store the file. This could be improved to look through all of the search paths and find one that is the closest to the provided path.

# Changes
- Added `move` command to the root command.
- `move.go` and `move_test.go hold implementation and testing for the `move` command respectively.
- Separated TTPRef parsing out from TTPRef resolution in `repocollection.go`.
- Updated `AbsPath()` in `fileutils.go` to resolve the actual absolute path following any symlinks.

Reviewed By: RoboticPrism

Differential Revision: D80826527
Pull Request #551: TTPForge Move Command

1655 of 3226 relevant lines covered (51.3%)

8.73 hits per line

Source Files on job 17239997386.1