4
97%
main: 97%

Ran 22 Aug 2025 07:00AM UTC

Files 8

Run time 0s

Badge

Embed ▾

Committed 22 Aug 2025 06:53AM UTC coverage: 97.429%. Remained the same

Job # 17148361819.4

Build Type

push

github

Committed by

francoisfreitag

Commit Message

Fix lost region when `PHONENUMBER_DEFAULT_FORMAT` is `NATIONAL`

When `PHONENUMBER_DEFAULT_FORMAT` is set to `NATIONAL`, you used to get a validation error after setting a `PhoneNumberField` to a phone number that is not in the default region.
This was because `PhoneNumberField` didn't override `to_python()`, so `CharField.to_python()` was called and returned `str(value)`.
Since `str(value)` returns a string in the `NATIONAL` format, the region information was lost.

I fixed this issue by overriding `to_python()` in  `PhoneNumberField`, ensuring that a `PhoneNumber` is returned.
This change forced me to move up the call to `super().get_prep_value()` because `CharField`'s implementation calls `self.to_python()`, which now returns a `PhoneNumber`.
This allowed me to remove `if isinstance(value, PhoneNumber)` in `get_prep_value()` since `value` is now always a `PhoneNumber`.

Run Details

341 of 350 relevant lines covered (97.43%)

0.97 hits per line

bblanchon / django-phonenumber-field / 17148361819 / 4
97%
main: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job Python 3.10 / - 17148361819.4

bblanchon / django-phonenumber-field / 17148361819 / 4 97% main: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job Python 3.10 / - 17148361819.4

bblanchon / django-phonenumber-field / 17148361819 / 4
97%
main: 97%

README BADGES
x