1
80%
master: 80%

Ran 21 Aug 2025 09:07AM UTC

Files 34

Run time 2s

Badge

Embed ▾

Committed 20 Aug 2025 09:58AM UTC coverage: 80.368%. Remained the same

Job # 17122293996.1

Build Type

push

github

Committed by

web-flow

Commit Message

xapi/nm: Send non-empty dns to networkd when using IPv6 autoconf (#6586)

Because Autoconf is not DHCP, networkd uses the dns value to write to
resolv.conf. This is done on ocaml/networkd/bin/network_server.ml line
745
This allows to have non-empty resolv.conf when using IPv6 autoconf.

This mismatch was caused byt technical debt that cause this check to be
duplicated, the second removes it so
xapi decides the instances where these values are written and networkd
follows that decision.

I've tested new isntallations using IPv4 and couldn't see any
regression, two users have tested the patch and now the DNS entries
don't get overriden when using IPv6 in Autoconf mode:
https://github.com/xcp-ng/xcp/issues/641#issuecomment-3094208413

I'd like Rob to review this approach in any case

Run Details

3496 of 4350 relevant lines covered (80.37%)

0.8 hits per line

xapi-project / xen-api / 17122293996 / 1
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 17122293996.1

xapi-project / xen-api / 17122293996 / 1 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python3.11 - 17122293996.1

xapi-project / xen-api / 17122293996 / 1
80%
master: 80%

README BADGES
x