spesmilo
/
electrum
/
5034298207633408
/
4
61%
master: 63%
master: 63%
|
Ran
|
Files
88
|
Run time
3s
|
Badge
Embed ▾
README BADGES
|
coverage: 61.337% (+0.04%) from 61.294%
CirrusCI
ecdsatxbatcher: be careful when removing local transactions 1. Do not remove local transaction in find_base_tx. This logic was intended to cleanup claim transactions that are never broadcast (for example, if the counterparty gets a refund) (see 1bf1de36c) However, this code is too unspecific and may result in fund loss, because the transaction being removed may contain outgoing payments. For example, if the electrum server is not responsive, the tx will be seen as local and deleted. In that case, another payment will be attempted, thus paying twice. 2. Do not remove tx after try_broadcasting returns False. The server might be lying to us. We can only remove the local tx if there is a base_tx, because the next tx we create will try to spend the same output.
22710 of 37025 relevant lines covered (61.34%)
0.61 hits per line
