mozilla-releng / balrog / #4705 / 1

90%

main: 90%

push

circleci

Don't use the `db_schema` fixture in `guardian_db` (#3448)

The db_schema fixture is session scopes while the guardian_db one is
module scoped. If the guardian_db fixture is used in tests that get
run out of order, the module fixture gets called again and explodes
because it's inserting into the session database again.

For example if tests are ran like this:

- test_json:A
- another_module:Foo
- test_json:B

It would result in:

- db_schema
- guardian_db
- test_json:A
- another_module:Foo
- guardian_db # BOOM
- test_json:B

This should hopefully fix the intermittent we've been seeing in test_json

3015 of 3535 branches covered (85.29%)

Branch coverage included in aggregate %.

5619 of 6148 relevant lines covered (91.4%)

0.91 hits per line