Qiskit
/
qiskit
/
15866047036
/
1
88%
main: 88%
main: 88%
|
Ran
|
Files
827
|
Run time
25s
|
Badge
Embed ▾
README BADGES
|
coverage: 87.988% (+0.008%) from 87.98%
push
github
web-flowUse Arc instead of Box for internal expression nodes in SymbolExpr (#14660) (#14665) This commit updates the internal construction of the SymbolExpr struct use a reference counting pointer instead of a regular pointer to a heap allocated object. The way the binary tree gets constructed internally using a normal pointer results in a lot of a copies of elements on the tree. This creates a large performance overhead for the symbol expr as we end up copying and freeing elements on the binary tree a large amount. This was the root cause of the regression reported in #14653 as the expression that gets generated by the transpiler internally ends up adding a lot of elements to global phase expression and that results in a lot of memory allocation and deallocation overhead. By using a reference counting pointer instead of creating and freeing copies of the expressions on the tree we instead only keep a single copy and just increment or decrement the reference count. Fixes #14653 (cherry picked from commit 3b2600202) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
83054 of 94392 relevant lines covered (87.99%)
516866.96 hits per line
