Ouranosinc / xsdba / 15741065418 / 4
79%
main: 79%

DEFAULT BRANCH: main
Ran
Files 23
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 75.327% (+0.2%) from 75.142%
15741065418.4

push

github

web-flow 
Clip bounds additive space (#165)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Additive_space defines `lower_bound` and possible `upper_bound`.
`data` should be $low < data < high$, else infinities arise. It
sometimes happens we have $low \leq data \leq high$ (e.g. hurs at
exactly 100%). For convenience, to_additive_space can now transform
$data \in [low, high] \to ]low, high[$ by adding/subtracting the
smallest float32 increments. If `data < low | data > high` this throws
an error if we try this procedure. We don't want the clipping to put
problems under the rug

### Does this PR introduce a breaking change?

No

### Other information:

@juliettelavoie I think it makes sense to have this directly in xsdba.
Here, I don't specify any clipping bounds, I think it's better to just
use whatever {lower,upper}_bound are given

In this way, xscen could simply set `clip_to_bounds = True` in the
arguments of `to_additive_space`

2650 of 3518 relevant lines covered (75.33%)

0.75 hits per line

Source Files on job run-Python3.13-conda - 15741065418.4