1
95%
main: 95%

Ran 04 Jun 2025 11:04PM UTC

Files 199

Run time 5s

Badge

Embed ▾

Committed 04 Jun 2025 10:55PM UTC coverage: 95.337%. Remained the same

Job # f88dec70-741f-4569-827e-f3dc4ca5fe0e.1

Build Type

Pull #4940

circleci

Committed by

sandbergja

Commit Message

Don't make HTTP requests to bibdata when creating FactoryBot factories

Requests::Patron effectively has a regular mode and an expensive mode
for initializing a new instance.  If you pass a patron_hash, it will
use the data from the hash.  If you don't, though, it will make an
HTTP call to bibdata to get the data.

For some reason, neither WebMock nor VCR seem to catch requests made
in factories!  And several of them were using the expensive initialize
version, making an HTTP call to bibdata-staging, getting "something
went wrong" since they weren't authenticated properly, and returning
no data anyway.  We can skip all that by providing an empty hash.

For me, this reduces the amount of time it takes to run
`bundle exec rspec -t requests` from 56 seconds to 48 seconds.

Helps with pulibrary/dacs_handbook#301

Pull Request Pull Request #4940: Don't make HTTP requests to bibdata when creating FactoryBot factories

Run Details

6032 of 6327 relevant lines covered (95.34%)

1516.01 hits per line

pulibrary / orangelight / f88dec70-741f-4569-827e-f3dc4ca5fe0e / 1
95%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job f88dec70-741f-4569-827e-f3dc4ca5fe0e.1

pulibrary / orangelight / f88dec70-741f-4569-827e-f3dc4ca5fe0e / 1 95% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job f88dec70-741f-4569-827e-f3dc4ca5fe0e.1

pulibrary / orangelight / f88dec70-741f-4569-827e-f3dc4ca5fe0e / 1
95%
main: 95%

README BADGES
x