bitcoindevkit / bdk / 15209940801 / 1

79%

master: 79%

push

github

Merge bitcoindevkit/bdk#1966: fix(chain): persist `first_seen`

<a class=hub.com/bitcoindevkit/bdk/commit/b27a019b595545ffe8fed6b77aeccb68f7b23938">b27a019b5 fix(chain): persist `first_seen` (Wei Chen)

Pull request description:

  Fixes #1965.

  ### Description

  Adds missing persistence for `first_seen`, which was not included in #1950.

  ### Changelog notice

  - Adds `first_seen` column to the `bdk_txs` table via schema v3 migration.
  - Updates `from_sqlite()` and `persist_to_sqlite()` to handle `first_seen`.
  - Updates the v0-to-v3 migration test to verify compatibility with older schemas.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK b27a019b595545ffe8fed6b77aeccb68f7b23938

Tree-SHA512: a8c4cd930fe10a2d77ba71c345e0e2ac5c4

5479 of 6583 relevant lines covered (83.23%)

31749.62 hits per line