1
79%
master: 80%

Ran 23 May 2025 08:49AM UTC

Files 68

Run time 1s

Badge

Embed ▾

Committed 23 May 2025 08:47AM UTC coverage: 79.115% (+0.007%) from 79.108%

Job # 15206244542.1

Build Type

Pull #723

github

Committed by

majewsky

Commit Message

simplify CanAcceptCommitmentChanges()

The previous implementation had a somewhat complicated exception case,
where the comment said "what this does is to check that usedCapacity
does not increase". This is a very weird situation: Why use a complex
condition when the condition in the comment is much easier to implement?
This commit does just that.

This came out of a conversation with a customer, who is trying to move
an unused commitment to another project on an AZ resource that is
overbooked (i.e. `usedCapacity > capacity`). Since the commitment is
unused in the donor project, this should be completely fine because
`usedCapacity` does not increase, but the previous implementation
rejected this change because it does not fall into its specific
exception case.

Pull Request Pull Request #723: simplify CanAcceptCommitmentChanges()

Run Details

6440 of 8140 relevant lines covered (79.12%)

48.37 hits per line

sapcc / limes / 15206244542 / 1
79%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 15206244542.1

sapcc / limes / 15206244542 / 1 79% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 15206244542.1

sapcc / limes / 15206244542 / 1
79%
master: 80%

README BADGES
x