letsencrypt / pebble / 15143827096 / 1
6%
master: 8%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Files 19
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 6.128% (-0.006%) from 6.134%
15143827096.1

Pull #500

github

tgeoghegan 
wfe: fix a race in `orderForDisplay`

I have an integration test for an ACME extension ([1]) that instantiate
Pebble. I noticed that I would sometimes get test failures under
`go test -race` like this:

```
==================
WARNING: DATA RACE
Write at 0x00c00026cd80 by goroutine 143:
  github.com/letsencrypt/pebble/v2/wfe.(*WebFrontEndImpl).orderForDisplay.func2()
      /home/timg/source/pebble/wfe/wfe.go:1876 +0x255
  math/rand.(*Rand).Shuffle()
      /usr/local/go/src/math/rand/rand.go:265 +0x96
  math/rand.Shuffle()
      /usr/local/go/src/math/rand/rand.go:470 +0x38
  github.com/letsencrypt/pebble/v2/wfe.(*WebFrontEndImpl).orderForDisplay()
      /home/timg/source/pebble/wfe/wfe.go:1875 +0x204
  github.com/letsencrypt/pebble/v2/wfe.(*WebFrontEndImpl).Order()
      /home/timg/source/pebble/wfe/wfe.go:2021 +0x5ed
  github.com/letsencrypt/pebble/v2/wfe.(*WebFrontEndImpl).Order-fm()
      <autogenerated>:1 +0x69
  github.com/letsencrypt/pebble/v2/wfe.(*WebFrontEndImpl).HandleFunc.func1()
      /home/timg/source/pebble/wfe/wfe.go:306 +0xa09
  github.com/letsencrypt/pebble/v2/wfe.wfeHandlerFunc.ServeHTTP()
      /home/timg/source/pebble/wfe/wfe.go:146 +0x56
  github.com/letsencrypt/pebble/v2/wfe.(*topHandler).ServeHTTP()
      /home/timg/source/pebble/wfe/wfe.go:158 +0x5b
  github.com/letsencrypt/pebble/v2/wfe.(*WebFrontEndImpl).HandleFunc.StripPrefix.func2()
      /usr/local/go/src/net/http/server.go:2282 +0x471
  net/http.HandlerFunc.ServeHTTP()
      /usr/local/go/src/net/http/server.go:2220 +0x47
  net/http.(*ServeMux).ServeHTTP()
      /usr/local/go/src/net/http/server.go:2747 +0x255
  net/http.serverHandler.ServeHTTP()
      /usr/local/go/src/net/http/server.go:3210 +0x2a1
  net/http.(*conn).serve()
      /usr/local/go/src/net/http/server.go:2092 +0x12a4
  net/http.(*Server).Serve.gowrap3()
      /usr/local/go/src/net/http/server.go:3360 +0x4f

Previous read at 0x00c00026cd80 by goroutine 274:
  github.com/letsencrypt/pebble/v2/ca.(*CAImpl).Comp... (continued)
Pull Request #500: wfe: fix a race in `orderForDisplay`

270 of 4406 relevant lines covered (6.13%)

0.29 hits per line

Source Files on job 15143827096.1