1
99%
master: 99%

Ran 08 May 2025 04:41PM UTC

Files 120

Run time 3s

Badge

Embed ▾

Committed 08 May 2025 04:31PM UTC coverage: 98.824%. Remained the same

Job # 14911401144.1

Build Type

push

github

Committed by

nemesifier

Commit Message

[fix] Fixed live updates for "Send commands"

Bug:
When multiple connections are made to the websocket command
endpoint of the same device (e.g. when multiple browser tabs are open for
the same device), the UI does not receive updates from the websocket and
keeps showing a loader in the command output field, even when the command
has completed execution.

Fix:
The issue was caused by mutating the shared `event` dictionary in the
`send_update` method of `CommandConsumer`. Specifically, calling
`event.pop('type')` removed the `'type'` key from the event. Since the
same event object is dispatched to all consumer instances (one for each
websocket connection), removing `'type'` in one instance caused the others
to raise:

    ValueError: Incoming message has no 'type' attribute

This broke message dispatch for the remaining connections. The fix is to
avoid modifying the original `event` dictionary.
This preserves the `'type'` key, ensuring all consumer instances
continue to receive well-formed events and function correctly.

Run Details

6305 of 6380 relevant lines covered (98.82%)

11.86 hits per line

openwisp / openwisp-controller / 14911401144 / 1
99%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python- - 14911401144.1

openwisp / openwisp-controller / 14911401144 / 1 99% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job python- - 14911401144.1

openwisp / openwisp-controller / 14911401144 / 1
99%
master: 99%

README BADGES
x