rust-bitcoin / rust-bitcoin / 14837811069 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#4434: [backport 0.32.x] bip32: return error when attempting to derive past maximum depth

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/315750deb3a74f82f28c9b388f0f57a38ebd3e62">315750deb bip32: return error when attempting to derive past maximum depth (Andrew Poelstra)

Pull request description:

  The corresponding PR on master is #4387, but this doesn't really resemble that PR. Rather than changing all the error enums, this just adds a new variant to the #[non_exhaustive] bip32::Error enum and returns that when adding 1 to 255 when deriving child keys.

  This is therefore not an API break and can be released in a minor version. Although it does change the error return on private derivation from a "succeeds except with negligible probability" to "there is an error path you may need to check for".

  Fixes #4308

ACKs for top commit:
  tcharding:
    ACK 315750deb3a74f82f28c9b388f0f57a38ebd3e62

Tree-SHA512: 8224a34622096617ea660ea4bc5e2a7e653

18629 of 22379 relevant lines covered (83.24%)

17360.86 hits per line