kubevirt
/
containerized-data-importer
/
#5262
/
1
49%
main: 49%
main: 49%
|
Ran
|
Files
155
|
Run time
5s
|
Badge
Embed ▾
README BADGES
|
coverage: 59.173% (+0.03%) from 59.141%
push
travis-ci
web-flowFix cdi-deployment Deployment selector (#3692) The cdi-deployment selector has a matchLabels value of {"app": "containerized-data-importer"} which is a common label that appears on many CDI related Pods (e.g., cdi-apiserver, cdi-uploadproxy, importer, etc.). This causes certain functionalities such as the log subresource to misbehave as it targets the first Pod of the Pod list according to the kubectl ByLogging sorting conditions[1]. This commit changes the cdi-deployment selector to the common "cdi.kubevirt.io" with the value "cdi-deployment". Since deployment selectors are immutable[2], it also adds a reconcile callback to delete the cdi-deployment Deployment in the event of detecting a selector that differs from the operator's desired one. [1] https://github.com/kubernetes/kubectl/blob/fec9d5b3d/pkg/util/podutils/podutils.go#L96 [2] https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#selector Signed-off-by: Adi Aloni <aaloni@redhat.com>
16830 of 28442 relevant lines covered (59.17%)
0.65 hits per line
