1
37%
master: 38%

Ran 20 Apr 2025 05:24AM UTC

Files 143

Run time 3s

Badge

Embed ▾

Committed 20 Apr 2025 05:22AM UTC coverage: 37.446% (-0.07%) from 37.515%

Job # 14556368249.1

Build Type

Pull #289

github

Committed by

tom93

Commit Message

Remove caching from controller permitted_params etc.

We don't call these methods multiple times during a single request, so
there is no point in caching the result. (The example from the
original strong_parameters gem doesn't use caching:
https://github.com/rails/strong_parameters.)

This also eliminates silly inconsistencies with what was cached -- in
some places it was @_permitted_params, while in other places it was
the intermediate @_permitted_attributes.

Also remove method `visible_attributes` from user_controller.rb, it's
unused since commit 8798951a (Refactor to remove the UserPresenter
service object (#165), 2023-02-18).

Pull Request Pull Request #289: Remove caching from controller permitted_params etc.

Run Details

2243 of 5990 relevant lines covered (37.45%)

5.65 hits per line

NZOI / nztrain / 14556368249 / 1
37%
master: 38%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14556368249.1

NZOI / nztrain / 14556368249 / 1 37% master: 38%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14556368249.1

NZOI / nztrain / 14556368249 / 1
37%
master: 38%

README BADGES
x