• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

jni / vispy / 14532569852 / 4
70%
master: 70%

Build:
Build:
LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran 18 Apr 2025 09:04AM UTC
Files 345
Run time 9s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 Apr 2025 12:23PM UTC coverage: 43.139% (+0.1%) from 43.015%
14532569852.4

push

github

web-flow
Various optimizations related to camera linking and mesh normals (#2532)

See #2530 

CC @jintaoLee-roger

This is a collection of optimizations uncovered in #2530 debugging by me
or @jintaolee-roger. The main ideas are to not update camera properties
unless the value has actually changed. This prevents expensive
transform-updating methods from being called unnecessarily. This is
especially noticeable when a single camera move updates 4+ properties of
a linked property and each one tries to report that the view/transform
has changed. It does this in two ways:

1. Don't execute a transform update if we're updating properties
2. Don't update a property (and signal a view change) if the property
value is the same

This PR also adds some checks in the mesh light filter to see if vertex
normals have actually changed before submitting/uploading the normals to
the GPU. It also enables the use of a previously unused (yet defined for
some reason?) `MeshData._vertex_normal_indexed_by_faces`. This allows
the check in the light filter to actually work with a simple identity
(`is`) check.


TODO:

* Testing of performance by @jintaolee-roger
* Adding tests for at least the normals caching in the meshdata.

---------

Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>

3414 of 10570 branches covered (32.3%)

Branch coverage included in aggregate %.

15069 of 32275 relevant lines covered (46.69%)

0.47 hits per line

Source Files on job run-1 - 14532569852.4
  • Tree
  • List 345
  • Changed 17
  • Source Changed 0
  • Coverage Changed 17
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 14532569852
  • cff17d30 on github
  • Prev Job for on main (#12291385307.2)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc