1
84%
master: 84%

Ran 24 Mar 2025 10:59PM UTC

Files 24

Run time 0s

Badge

Embed ▾

Committed 24 Mar 2025 10:57PM UTC coverage: 83.688% (+0.1%) from 83.582%

Job # 14047623432.1

Build Type

Pull #241

github

Committed by

paskal

Commit Message

Set cookies for OAuth flows when SendJWTHeader is enabled

This fixes https://github.com/umputun/remark42/issues/1877 where OAuth
 authentication
fails when the send-jwt-header option is enabled. The problem occurred
 because:

1. When SendJWTHeader is enabled, the auth service only sends the JWT
as a header
   without setting cookies
2. During OAuth flows, the authentication involves redirects between
the app and the
   provider
3. HTTP headers don't persist through redirects, so the authentication
 state was lost

The solution:
- Modified the jwt.go token Set method to always set cookies during
OAuth handshake
  phases (when claims.Handshake != nil), even when SendJWTHeader is
enabled
- For normal authentication (non-handshake), maintain the original
behavior where
  SendJWTHeader=true will only set headers
- This ensures the OAuth flow works properly while maintaining the
correct behavior
  for API requests

Pull Request Pull Request #241: Set cookies for OAuth flows when SendJWTHeader is enabled

Run Details

2678 of 3200 relevant lines covered (83.69%)

7.18 hits per line

go-pkgz / auth / 14047623432 / 1
84%
master: 84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14047623432.1

go-pkgz / auth / 14047623432 / 1 84% master: 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14047623432.1

go-pkgz / auth / 14047623432 / 1
84%
master: 84%

README BADGES
x