PHPCSStandards / PHP_CodeSniffer / 14007039587 / 4
78%
master: 79%

LAST BUILD BRANCH: fix/interface-indentation
DEFAULT BRANCH: master
Ran
Files 263
Run time 6s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 73.883%. Remained the same
14007039587.4

push

github

jrfnl 
PropertyTypeHandlingTest: split data provider

The `PropertyTypeHandlingTest` class tests the setting of property values from the ruleset as well as via inline `// phpcs:set ...`  annotations.

As both ways of setting the property value should be supported in the same manner, the tests used one data provider for both tests and the fixtures (`PropertyTypeHandlingTest.xml` ruleset and the `Fixtures/PropertyTypeHandlingInline.inc` file containing the inline annotations) mirrored the exact same test cases.

There is one feature, however, which is only supported when setting properties via the ruleset, not when setting them via inline annotations: array property extending.

Until now, the tests for that were also mirrored in the inline annotation tests, even though the feature isn't supported for inline annotations.

This commit now splits the data provider in two:
* One data provider for the tests which apply for both (= most tests).
* One specifically for extending array properties.

That second data provider will now only be used by the `testTypeHandlingWhenSetViaRuleset()` test method.

This should make it more straight-forward to add additional tests for property extending in the future.

---

In case anyone is wondering: As `phpcs:set` is only supposed to be used in tests, I don't think adding support for the `extend` option to inline properties is necessary.

18215 of 24654 relevant lines covered (73.88%)

25.61 hits per line

Source Files on job os-ubuntu-latest-php-7.2-custom-ini-false - 14007039587.4